free_cmndspec: plug apparmor_profile leak

sudo-project · May 3, 2024 · 07d6aa2 · 07d6aa2
1 parent 89918ca
commit 07d6aa2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/plugins/sudoers/gram.c b/plugins/sudoers/gram.c
@@ -3763,6 +3763,11 @@ free_cmndspec(struct cmndspec *cs, struct cmndspec_list *csl)
 	(next == NULL || cs->type != next->type)) {
 	free(cs->type);
     }
+    /* Don't free apparmor_profile that is in use by other entries. */
+    if ((prev == NULL || cs->apparmor_profile != prev->apparmor_profile) &&
+	(next == NULL || cs->apparmor_profile != next->apparmor_profile)) {
+	free(cs->apparmor_profile);
+    }
     /* Don't free privs/limitprivs that are in use by other entries. */
     if ((prev == NULL || cs->privs != prev->privs) &&
 	(next == NULL || cs->privs != next->privs)) {

diff --git a/plugins/sudoers/gram.y b/plugins/sudoers/gram.y
@@ -1580,6 +1580,11 @@ free_cmndspec(struct cmndspec *cs, struct cmndspec_list *csl)
 	(next == NULL || cs->type != next->type)) {
 	free(cs->type);
     }
+    /* Don't free apparmor_profile that is in use by other entries. */
+    if ((prev == NULL || cs->apparmor_profile != prev->apparmor_profile) &&
+	(next == NULL || cs->apparmor_profile != next->apparmor_profile)) {
+	free(cs->apparmor_profile);
+    }
     /* Don't free privs/limitprivs that are in use by other entries. */
     if ((prev == NULL || cs->privs != prev->privs) &&
 	(next == NULL || cs->privs != next->privs)) {