Skip to content

Commit

Permalink
Use long, not long long, when getting/setting numeric attributes.
Browse files Browse the repository at this point in the history
We use int or long, not long long, in the Python plugin.
  • Loading branch information
millert committed Sep 27, 2023
1 parent 1398289 commit 344e0da
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions plugins/python/pyhelpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -522,20 +522,20 @@ py_object_get_optional_attr_string(PyObject *py_object, const char *attr_name)
return value;
}

long long
long
py_object_get_optional_attr_number(PyObject *py_object, const char *attr_name)
{
PyObject *py_value = py_object_get_optional_attr(py_object, attr_name, NULL);
if (py_value == NULL)
return -1;

long long value = PyLong_AsLongLong(py_value);
long value = PyLong_AsLong(py_value);
Py_CLEAR(py_value);
return value;
}

void
py_object_set_attr_number(PyObject *py_object, const char *attr_name, long long number)
py_object_set_attr_number(PyObject *py_object, const char *attr_name, long number)
{
PyObject *py_number = PyLong_FromLong(number);
if (py_number == NULL)
Expand Down
4 changes: 2 additions & 2 deletions plugins/python/pyhelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ CPYCHECKER_RETURNS_BORROWED_REF
PyObject *py_tuple_get(PyObject *py_tuple, Py_ssize_t index, PyTypeObject *expected_type);

PyObject *py_object_get_optional_attr(PyObject *py_object, const char *attr, PyObject *py_default);
long long py_object_get_optional_attr_number(PyObject *py_object, const char *attr_name);
long py_object_get_optional_attr_number(PyObject *py_object, const char *attr_name);
const char *py_object_get_optional_attr_string(PyObject *py_object, const char *attr_name);

void py_object_set_attr_number(PyObject *py_object, const char *attr_name, long long number);
void py_object_set_attr_number(PyObject *py_object, const char *attr_name, long number);
void py_object_set_attr_string(PyObject *py_object, const char *attr_name, const char *value);

PyObject *py_create_version(unsigned int version);
Expand Down

0 comments on commit 344e0da

Please sign in to comment.