Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give every printf-like function restrict qualifiers #287

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

AreaZR
Copy link
Contributor

@AreaZR AreaZR commented Jul 7, 2023

The format value has to be a string literal, every time.

Otherwise, you are not using these functions correctly. To reinforce this fact, I putrestrict over every non-contrib example of this I could find.

@AreaZR AreaZR force-pushed the restrict branch 2 times, most recently from 6d0b3f7 to e265a7e Compare July 7, 2023 20:36
Copy link
Collaborator

@millert millert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to keep unrelated changes separate.

lib/eventlog/logwrap.c Outdated Show resolved Hide resolved
plugins/sudoers/ldap_util.c Outdated Show resolved Hide resolved
plugins/sudoers/ldap_util.c Outdated Show resolved Hide resolved
@AreaZR AreaZR force-pushed the restrict branch 4 times, most recently from f9b19b0 to 57ff627 Compare July 7, 2023 23:20
@AreaZR AreaZR requested a review from millert July 7, 2023 23:20
@AreaZR AreaZR changed the title Give every printf like function __restrict for the format value Give every printf like function restrict for the format value Jul 7, 2023
@AreaZR AreaZR force-pushed the restrict branch 3 times, most recently from 78aac43 to da00f18 Compare July 8, 2023 00:21
@AreaZR AreaZR changed the title Give every printf like function restrict for the format value Give every printf-like function restrict qualifiers Jul 8, 2023
The format value has to be a string literal, every time.

Otherwise, you are not using these functions correctly. To reinforce this fact, I putrestrict over every non-contrib example of this I could find.
@millert millert merged commit fc02df1 into sudo-project:main Jul 8, 2023
4 checks passed
@AreaZR AreaZR deleted the restrict branch October 10, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants