Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning with hasChildQuery #13

Closed
piotrkochan opened this issue Jul 10, 2017 · 1 comment
Closed

Deprecation warning with hasChildQuery #13

piotrkochan opened this issue Jul 10, 2017 · 1 comment

Comments

@piotrkochan
Copy link

piotrkochan commented Jul 10, 2017 •
edited
Loading

Deprecated field [child_type] used, expected [type] instead

Generated query:

{
     "has_child": {
        "child_type": "child_documents",
        "query": {
        "bool": {
            "must": [
                ...

Used version: 1.0.0
sudo-suhas added a commit that referenced this issue Jul 10, 2017
@sudo-suhas
fix: Fix deprecation warning for HasChildQuery.type
82058e3 
`child_type` field in `has_child` query is deprecated.
Change `has_child>child_type` => `has_child>type`
Closes #13
@sudo-suhas sudo-suhas mentioned this issue Jul 10, 2017
Merged
@sudo-suhas
Copy link
Owner

sudo-suhas commented Jul 10, 2017 •
edited
Loading

Hey @piotrkochan, thanks for reporting this issue! I have fixed and released it in v1.0.1.

@piotrkochan piotrkochan changed the title Deprecation warning witch hasChildQuery Deprecation warning with hasChildQuery Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piotrkochan @sudo-suhas