Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement 'Bucket Sort Aggregation' #69

Merged
merged 2 commits into from
Sep 27, 2018
Merged

feat: Implement 'Bucket Sort Aggregation' #69

merged 2 commits into from
Sep 27, 2018

Conversation

dimatill
Copy link
Contributor

Adds implementation of Bucket Sort Aggregation https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html

Usage example:

const reqBody = esb.requestBodySearch()
     .agg(
         esb.bucketSortAggregation('sort')
             .sort([
                  esb.sort('user', 'desc')
              ])
              .from(5)
              .size(10)
         )
     );

Copy link
Owner

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor change request, otherwise the PR is very thorough. Thank you!

/**
* Sets the list of fields to sort on. Optional.
*
* [Elasticsearch reference](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html#id-1.9.5.55.4.6)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is necessary to repeat the URL for reference and example in every method's docs. Could you please remove them?

@XBeg9
Copy link

XBeg9 commented Sep 27, 2018

@sudo-suhas hi, any updates here? looking forward to getting this merged. Thanks.

@sudo-suhas sudo-suhas merged commit 50f8175 into sudo-suhas:master Sep 27, 2018
@sudo-suhas
Copy link
Owner

Merged and released in elastic-builder@2.1.0 🎉

@XBeg9
Copy link

XBeg9 commented Sep 27, 2018

@sudo-suhas that's great! Thanks

@XBeg9 XBeg9 deleted the feature/ASU-91 branch September 27, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants