-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement 'Bucket Sort Aggregation' #69
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
src/aggregations/pipeline-aggregations/bucket-sort-aggregation.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
'use strict'; | ||
|
||
const PipelineAggregationBase = require('./pipeline-aggregation-base'); | ||
|
||
const ES_REF_URL = | ||
'https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html'; | ||
|
||
/** | ||
* A parent pipeline aggregation which sorts the buckets of its parent | ||
* multi-bucket aggregation. Zero or more sort fields may be specified | ||
* together with the corresponding sort order. Each bucket may be sorted | ||
* based on its _key, _count or its sub-aggregations. In addition, parameters | ||
* from and size may be set in order to truncate the result buckets. | ||
* | ||
* [Elasticsearch reference](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html) | ||
* | ||
* @example | ||
* const reqBody = esb.requestBodySearch() | ||
* .agg( | ||
* esb.bucketSortAggregation('sort') | ||
* .sort([ | ||
* esb.sort('user', 'desc') | ||
* ]) | ||
* .from(5) | ||
* .size(10) | ||
* ) | ||
* ); | ||
* | ||
* @param {string} name The name which will be used to refer to this aggregation. | ||
* | ||
* @extends PipelineAggregationBase | ||
*/ | ||
class BucketSortAggregation extends PipelineAggregationBase { | ||
// eslint-disable-next-line require-jsdoc | ||
constructor(name) { | ||
super(name, 'bucket_sort', ES_REF_URL); | ||
} | ||
|
||
/** | ||
* Sets the list of fields to sort on. Optional. | ||
* | ||
* [Elasticsearch reference](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html#id-1.9.5.55.4.6) | ||
* | ||
* @example | ||
* const reqBody = esb.requestBodySearch() | ||
* .agg( | ||
* esb.bucketSortAggregation('sort') | ||
* .sort([ | ||
* esb.sort('user', 'desc') | ||
* ]) | ||
* .from(5) | ||
* .size(10) | ||
* ) | ||
* ); | ||
* | ||
* @param {Array<Sort>} sort The list of fields to sort on | ||
* @returns {BucketSortAggregation} returns `this` so that calls can be chained | ||
*/ | ||
sort(sort) { | ||
this._aggsDef.sort = sort; | ||
return this; | ||
} | ||
|
||
/** | ||
* Sets the value buckets in positions prior to which will be truncated. Optional. | ||
* | ||
* [Elasticsearch reference](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html#id-1.9.5.55.4.6) | ||
* | ||
* @example | ||
* const reqBody = esb.requestBodySearch() | ||
* .agg( | ||
* esb.bucketSortAggregation('sort') | ||
* .sort([ | ||
* esb.sort('user', 'desc') | ||
* ]) | ||
* .from(5) | ||
* .size(10) | ||
* ) | ||
* ); | ||
* | ||
* @param {number} from Buckets in positions prior to the set value will be truncated. | ||
* @returns {BucketSortAggregation} returns `this` so that calls can be chained | ||
*/ | ||
from(from) { | ||
this._aggsDef.from = from; | ||
return this; | ||
} | ||
|
||
/** | ||
* Sets the number of buckets to return. Optional. | ||
* | ||
* [Elasticsearch reference](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-bucket-sort-aggregation.html#id-1.9.5.55.4.6) | ||
* | ||
* @example | ||
* const reqBody = esb.requestBodySearch() | ||
* .agg( | ||
* esb.bucketSortAggregation('sort') | ||
* .sort([ | ||
* esb.sort('user', 'desc') | ||
* ]) | ||
* .from(5) | ||
* .size(10) | ||
* ) | ||
* ); | ||
* | ||
* @param {number} size The number of buckets to return. | ||
* @returns {BucketSortAggregation} returns `this` so that calls can be chained | ||
*/ | ||
size(size) { | ||
this._aggsDef.size = size; | ||
return this; | ||
} | ||
} | ||
|
||
module.exports = BucketSortAggregation; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import test from 'ava'; | ||
import { BucketSortAggregation, Sort } from '../../src'; | ||
import { setsAggType } from '../_macros'; | ||
|
||
const getInstance = () => new BucketSortAggregation('my_agg'); | ||
|
||
test(setsAggType, BucketSortAggregation, 'bucket_sort'); | ||
|
||
test('can be instantiated', t => { | ||
const value = getInstance().toJSON(); | ||
const expected = { | ||
my_agg: { | ||
bucket_sort: {} | ||
} | ||
}; | ||
t.deepEqual(value, expected); | ||
}); | ||
|
||
test('sort from and size are set', t => { | ||
const value = getInstance() | ||
.sort([new Sort('myField', 'desc')]) | ||
.from(5) | ||
.size(10) | ||
.toJSON(); | ||
|
||
const expected = { | ||
my_agg: { | ||
bucket_sort: { | ||
sort: [ | ||
{ | ||
myField: 'desc' | ||
} | ||
], | ||
from: 5, | ||
size: 10 | ||
} | ||
} | ||
}; | ||
t.deepEqual(value, expected); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is necessary to repeat the URL for reference and example in every method's docs. Could you please remove them?