When using esb.sort().script(...)

[yoonhoGo]

If esb.sort() is used without field parameter to use esb.sort().script(...), We should omit field parameter.
This case is expression in the script section of the document page.

[yoonhoGo]

Reviewer: @sudo-suhas

[sudo-suhas]

Let's do the change in the following places to annotate the field argument to esb.sort() as optional:

• elastic-builder/src/core/sort.js

  Line 34 in 59c951d

  * @param {string} field The field to sort on

• elastic-builder/src/index.d.ts

  Lines 8261 to 8266 in 59c951d

  	* @param {string} field The field to sort on
  	* @param {string=} order The `order` option can have the following values.
  	* `asc`, `desc` to sort in ascending, descending order respectively.
  	*/
  	export class Sort {
  	constructor(field: string, order?: string);

• elastic-builder/src/index.d.ts

  Lines 8420 to 8424 in 59c951d

  	* @param {string} field The field to sort on
  	* @param {string=} order The `order` option can have the following values.
  	* `asc`, `desc` to sort in ascending, descending order respectively.
  	*/
  	export function sort(field: string, order?: string): Sort;

Additionally, in the sort constructor, _field property should only be set if it isn't nil.

[sudo-suhas]

Just annotating the field parameter for existing function and constructor declarations should be enough, no need to add the overriding function declaration.

[sudo-suhas]

This could be reworded as

Suggested change

	* If `.script()` function is used, It will be omitted.
	* If a script is used to specify the sort order, `field` should be omitted.

Could you please do these changes in the 3 places? I apologise for the redundancy, I am planning to do something about it sometime soon.

[yoonhoGo]

That's so easy. 😄

[sudo-suhas]

I agree that it's easy but it's also easy to miss and not obvious that the same changes have to made in multiple places. Nevertheless, I appreciate your patience and cooperation.

[sudo-suhas]

Thank you @yoonhoGo for the PR! Changes merged in and released in v2.2.2 🎉

[yoonhoGo]

Thank you @sudo-suhas. You're so very kind!