Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue.remove(testFn) #56

Merged
merged 5 commits into from
Oct 3, 2017
Merged

Add queue.remove(testFn) #56

merged 5 commits into from
Oct 3, 2017

Conversation

yles9056
Copy link
Contributor

@yles9056 yles9056 commented Oct 3, 2017

Add queue.remove(testFn) to Neo-Async v2.4.0
This function is from Async v2.5.0

Add queue.remove(testFn) to Neo-Async v2.4.0
This function is from Async v2.5.0
@codecov-io
Copy link

codecov-io commented Oct 3, 2017

Codecov Report

Merging #56 into master will decrease coverage by 0.06%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage     100%   99.93%   -0.07%     
==========================================
  Files           2        2              
  Lines        3146     3167      +21     
==========================================
+ Hits         3146     3165      +19     
- Misses          0        2       +2
Impacted Files Coverage Δ
lib/async.js 99.93% <90.47%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c32f8...b72ab44. Read the comment docs.

@suguru03
Copy link
Owner

suguru03 commented Oct 3, 2017

@yles9056 Thank you for your PR! :)
Dist files are generated automatically, could you add the feature to the main file? Also if you are able to add these test cases, it would be helpful.

Add queue.remove(testFn) to Neo-Async v2.4.0
This function is from Async v2.5.0
test for queue.remove()
Add queue.remove()
Add queue.remove()
@yles9056
Copy link
Contributor Author

yles9056 commented Oct 3, 2017

@suguru03
Sorry, I tried several times, but couldn't get it work.
I added test case for queue.remove() and ran several tests on my computer to make sure everything works.
But it just can't pass the online coverage test when I upload the files. The reason is unknown.

@suguru03
Copy link
Owner

suguru03 commented Oct 3, 2017

@yles9056 Thank you for adding test cases and fixing it.
Test cases are fine, it is only coverage problem. I'll handle it. 😄

@suguru03 suguru03 merged commit c5e7d6f into suguru03:master Oct 3, 2017
@yles9056
Copy link
Contributor Author

yles9056 commented Oct 3, 2017

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants