Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and support for Conrad_RS-200 protocol #313

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

to-scho
Copy link
Contributor

@to-scho to-scho commented Jan 2, 2020

There is a tiny bug hat prevents the usage for "Conrad RS-200" based devices. The RS-200 protocol does not repeat packets that often. One need already to detect the end of the first packet. The gap between two transmission are not handled right when RF packet is received first time.

a) 1st gap detection fixed
b) Furthermore the "Conrad RS-200" protocol is added.

There is a tiny bug hat prevents the usage for "Conrad RS-200" based devices. The RS-200 protocol does not repeat packets that often. One need already to detect the end of the first packet. The gap between two transmission are not handled right when RF packet is received first time.

a) 1st gap detection fixed
b) Furthermore the "Conrad RS-200" protocol is added.
@1technophile
Copy link
Collaborator

Thanks for this PR, did you add the chance to test your modification with other protocols to see if in the real there is no side effects?

@to-scho
Copy link
Contributor Author

to-scho commented Jan 5, 2020

Yes, but I have just one other at hand. It also works well with my PIR sensor from SonOff.
I found that first packed gap is not recognized using a scope. When there is no reason that first gap / two packets are not enough it looked just like tiny bug of the first iteration to me.

@1technophile
Copy link
Collaborator

1technophile commented Jan 5, 2020

I will do some tests on my side.
Would it be possible to share the results of simpleRcscanner if available, and the expected decoding.
The goal is to include them into future unit testing.

@to-scho
Copy link
Contributor Author

to-scho commented Jan 5, 2020

Sorry, I haven't used simpleRcscanner

@1technophile
Copy link
Collaborator

1technophile commented Jan 5, 2020

And would it be possible to capture at least 4 or 5 recordings for future use and in the mean time the corresponding results with your modified code?

@to-scho
Copy link
Contributor Author

to-scho commented Jan 5, 2020

ouch, my experiments with that are half a year ago. I know, very late PR...

I need to reflash my working device. This may take a while.

@1technophile
Copy link
Collaborator

No problem, we will not setup unit testing fast, the goal is just to have some date in input /results to avoid regressions.

@to-scho
Copy link
Contributor Author

to-scho commented Jan 5, 2020

One thing came into my mind. I started experiments using rc-switch because of this two issues reported here:

(Conrad) RS-200 switch is too noisy? #228
Conrad RS-200 Sockets / Europe Supplies Ltd. RS-200 #231

The latter one decoded the rc-200 protocol completely. My issue and PR is about receiving it.

In that posts there are some traces. Is that sufficient for you?

@1technophile
Copy link
Collaborator

Thanks I will check

@1technophile
Copy link
Collaborator

Tests are ok for me

@1technophile 1technophile merged commit b86871e into sui77:master Jan 16, 2020
@to-scho to-scho deleted the hotfix/Conrad_RS-200 branch January 16, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants