chore: refactor notification tray while onclick auto scroll to phone … #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
force-pushed
the
suisin/pnv/notification_onclick_scroll_to_phone_field
branch
6 times, most recently
from
c1b0663
to
4c8c4d5
Compare
packages/account/src/Sections/Profile/PersonalDetails/personal-details-form.tsx
Show resolved
Hide resolved
fasihali-deriv
approved these changes
Aug 27, 2024
matin-deriv
reviewed
Aug 27, 2024
likhith-deriv
approved these changes
Aug 27, 2024
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/personal-details-form.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/personal-details-form.tsx
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/personal-details-form.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PhoneVerification/__test__/confirm-phone-number.spec.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PhoneVerification/phone-verification-page.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PhoneVerification/phone-verification-page.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Aug 27, 2024
packages/account/src/Sections/Profile/PhoneVerification/resend-code-timer.tsx
Outdated
Show resolved
Hide resolved
…field in personal details
…unction to return only numbers
…se for verify button
…er to verify button
…ation and link expired modal
suisin-deriv
force-pushed
the
suisin/pnv/notification_onclick_scroll_to_phone_field
branch
from
0f45044
to
d874db1
Compare
amina-deriv
approved these changes
Aug 27, 2024
suisin-deriv
merged commit 41e3cf2
into
suisin/utkarsha/UPM819/phone_verification_flow
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…field in personal details
Changes:
on Click pnv notification, in notification tray, should bring user to personal details screen and auto scrolls to phone number field
Screenshots:
Please provide some screenshots of the change.