Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

likhith/migrate read-more to tsx #28

Merged
merged 2 commits into from
Nov 3, 2022
Merged

likhith/migrate read-more to tsx #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8504ed3
refactor: :art: migrate read-more to tsx
likhith-deriv Oct 7, 2022
360f232
Merge branch 'suisin/79116/ts_migration_parent' into likhith/76923/mi…
likhith-deriv Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ponents/src/components/read-more/index.js → ...ponents/src/components/read-more/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import ReadMore from './read-more.jsx';
import ReadMore from './read-more';
import './read-more.scss';

export default ReadMore;
21 changes: 10 additions & 11 deletions ...ts/src/components/read-more/read-more.jsx → ...ts/src/components/read-more/read-more.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
import React from 'react';
import classNames from 'classnames';
import PropTypes from 'prop-types';

const ReadMore = ({ className, collapse_length, expand_text, openDialog, show_dialog, text }) => {
type TReadMore = {
className?: string;
collapse_length: number;
expand_text: string;
openDialog: () => void;
show_dialog?: boolean;
text: string;
};

const ReadMore = ({ className, collapse_length, expand_text, openDialog, show_dialog, text }: TReadMore) => {
const [content, updateContent] = React.useState('');
const [is_collapsed, setIsCollapsed] = React.useState(true);

Expand Down Expand Up @@ -41,14 +49,5 @@ const ReadMore = ({ className, collapse_length, expand_text, openDialog, show_di
</React.Fragment>
);
};
ReadMore.propTypes = {
className: PropTypes.string,
collapse_length: PropTypes.number,
collapse_text: PropTypes.string,
expand_text: PropTypes.string,
openDialog: PropTypes.func,
show_dialog: PropTypes.bool,
text: PropTypes.string,
};

export default ReadMore;