Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix POI and POA issue #62

Merged
merged 2 commits into from
Oct 13, 2023
Merged

chore: fix POI and POA issue #62

merged 2 commits into from
Oct 13, 2023

Conversation

suisin-deriv
Copy link
Owner

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fixed the flow for POI and POA which is causing error when redirect from real account creation

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@amina-deriv amina-deriv merged commit ad845a6 into suisin/DIEL_flow_change Oct 13, 2023
1 check failed
suisin-deriv pushed a commit that referenced this pull request Dec 29, 2023
@likhith-deriv @yauheni-deriv
[account-v2]/likhith/chore: initial setup (binary-com#12315)
37c8084 
* chore: initial setup

* chore: initial setup

* chore: configured webpack

* fix: changed lint rules

* chore: incorporated build config

* chore: added stylelint file

* chore: updated stylelint

* refactor: incorporated review comments

* fix: reverted webpack types

* fix: build issue

* chore: added libs

* Likhith webpack to ts (#62)

* chore: added sonarlint rules

* chore: added a test component

* chore: webpack config refactor

* fix: removed test component

* chore: copied tailwind from tradershub

* fix: dependency version mismatch

* fix: added feaure-flag to guard route

* chore: fix type of build

* feat: added quill icons lib

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

* fix: removed unused external

* fix: sonarlint issues

* fix: build issue

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
suisin-deriv pushed a commit that referenced this pull request Jun 5, 2024
@maryia-deriv @kate-deriv @balakrishna-deriv
[DTRA] Kate/Maryia/DTRA-1279/Redesign: Positions page (binary-com#15234)
672615a 
* chore: empty commit

* feat: tabs + background + initialized EmptyMessage component

* Maryia/Positions-redesign/improve EmptyMessage component + add tests (#50)

* feat: redirect to trade upon button click on the empty page

* test: EmptyMessage

* chore: empty commit

* DTRA-1279 / Kate / Filter [WIP] (#51)

* feat: add dropdowm and action sheet

* feat: add apply functionality

* chore: remove unused functionality

* refactor: separate apply logic

* feat: add clear all functionality

* feat: apply filtration logic

* fix: filtration bug

* chore: rename variables

* refactor: extract filtration logic into a util function

* chore: empty commit

* fix: sonarcloud issues

* chore: empty commit

* chore: add modules store  and useclosedposition hook (#52)

* refactor: remove todo and change some prop based on quill updates (#54)

* DTRA-1279 / Kate / Use hook for real data (#55)

* feat: use hook for real data

* refactor: apply suggestions

* Maryia/positions-redesign/Contract cards [WIP] (#53)

* feat: init ContractCard

* feat: Contract cards

* feat: use ReportsStoreProvider

* style: remove unnecessary comment

* fix: key

* fix: remove old card styles

* fix: types

* fix: use contract_info in filterPositions

* fix: do not show buttons for sold contracts

* DTRA-1279 / Kate / Refactor handling open and closed positions and their filtration (#56)

* refactor: move stor values to poitions content file

* chore: remove code smell

* Maryia/positions-redesign/Contract cards improvements + fetching Open positions + formatProfitTableTransactions TS migration (#58)

* refactor: contract-card-list and card

* feat: buttons demo + animation improvements

* feat: finilize Duration component for the card

* chore: ts migration for closed positions

* fix: console error with remaining time & showing empty message only when empty

* feat: connect real open postions + style and filter fixes

* fix: style

* DTRA-1279/ Kate / Create filter component  (#57)

* feat: create new filter component

* feat: apply radio button

* refactor: default time filter logic

* feat: add time filtration

* refactor: remove unused css

* DTRA-1279 / Kate / Refactor: add new content for empty page (#59)

* refactor: add new content for empty page

* chore: test text update

* Maryia/positions-redesign/Contract cards data update fix (#61)

* fix: Accumulators tick passed count

* fix: contract cards update

* fix: show loading only when should not show empty message or cards

* chore: update quill version (#63)

* Maryia/positions-redesign/Contract card loading state and status timer updates + EmptyPositions update (#64)

* feat: loading functionality + fix for status timer

* chore: update copy for empty-positions

* revert: use hasActionButtons prop instead of impicit onClose

* DTRA-1279/ Kate/ Feat: add Date picker (#62)

* feat: add second action sheet

* feat: add date range formatting and refactored existing code

* feat: add range selection filtration

* refactor: chip and time filter

* fix: empty posituions after filtration

* refactor: do clean up

* chore: rename variables

* chore: localization

* DTRA-1279 / Kate/ Add filtration hooks  (#65)

* feat: create hooks

* refactor: rename methods

* DTRA-1279 / Kate / Add tests  (#66)

* refactor: add tests for chip component

* refactor: add tests for date picker

* refactor: add tests for contract type filter

* refactor: add tests for custom time filter button

* refactor: add tests for positions utils

* DTRA-1279 / Kate / Double filtration and extra filter options (#67)

* fix: filtration for today and yersterday

* fix: double filter

* refactor: change style after design confirmation and sort props

* refactor: start adding tets for time filter

* chore: apply suggestions

* chore: update quill and token library version

* DTRA-1279 / Kate / Add section separator  (#68)

* feat: add sections with date

* feat: make filter always visible

* refactor: style for date separator

* refactor: format time function

* refactor: add tests

* chore: remove unused wrapper

* chore: apply suggestions

* DTRA-1279 / Kate / Tech Debt (#69)

* refactor: add more test cases for time-filter

* refactor: add tests for hooks

* refactor: removed some todos

* Maryia/positions-redesign/finilise contract card + add total profit loss + initiate pagination in closed positions (#70)

* refactor: utilize Tag in ContractCardStatusTimer

* chore: add opacity transition to buttons when revealing/hiding them

* feat: add total profit + improve card

* fix: card deletion transition + total pnl positioning

* feat: add pagination on scroll (initial version)

* fix: loading state and loading more on infinite scroll in Closed tab (#71)

* DTRA-1279 / Kate / Tech Debt part 2 [WIP] (#72)

* refactor: add tests for utils functions + removed unused hook

* refactor: move total profit loss to a separate folder and add  tests

* refactor: add tests for positions

* refactor: add tests for position content file

* Maryia/positions-redesign/test contract card + fix scroll behavior, dates formatting, and filtering Closed positions (#73)

* test: contract-card

* fix: hide filters on scroll + utilize moment for formatting date in closed tab

* refactor: update quill version and refactor

* refactor: chip component (#74)

* refactor: position content page

* Maryia/positions-redesign/test: ContractCardList, ContractCardStatusTimer, PositionsStore, getCurrentTick() + refactoring (#75)

* test: contract-card-list

* test: ContractCardStatusTimer

* test: getCurrentTick() in contract.tsx in shared

* test: PositionsStore

* test: add more tests to ContractCardList

* refactor: desctructure props in mocked component

* Maryia/positions-redesign/fix: tests + address sonarcloud + use clsx (#76)

* fix: tests + address sonarcloud

* refactor: use clsx instead of classnames

* refactor: sonarcloud - reduce complexity

* fix: cards filtering in PositionsContent + tests + style+bug fixes

* build: trigger checks

* fix: hasNoActiveFilters condition

* fix: update package version and remove prop from action sheet

* chore: rename function

* Maryia/positions-redesign/feat: display correct active positions count (#77)

* feat: display correct active positions count

* fix: BottomNav tests

* refactor: filter behaviour

* chore: add padding

* fix: positions count in footer to not show 0 (#78)

* refactor: total profit loss

* chore: add tests for tpl and refactor date picker

* refactor: add loadre inside of empty positions

* fix: tests

* Maryia/positions-redesign/fix: loader on infinite scroll in Closed tab + make redirectTo prop optional in ContractCard (#79)

* fix: place loading after contract cards sections

* chore: make redirection optional when clicking on contract card

* chore: rename timet

* DTRA-1279 / Kate / Add a single date selection (#80)

* feat: add partial range

* refactor: tests

* refactor: callback

---------

Co-authored-by: kate-deriv <kate@regentmarkets.com>
Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com>
Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@shaheer-deriv shaheer-deriv shaheer-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suisin-deriv @amina-deriv @shaheer-deriv