Suisin/upm826/success modal phone number verification #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amina-deriv
reviewed
May 9, 2024
packages/stores/types.ts
Outdated
| @@ -744,6 +744,8 @@ type TUiStore = { | |||
| setRealAccountSignupEnd: (status: boolean) => void; | |||
| setPurchaseState: (index: number) => void; | |||
| simple_duration_unit: string; | |||
| should_show_phone_number_verified_modal: boolean; | |||
There was a problem hiding this comment.
do we need this observer ?
This modal will be triggered only when phone number otp is verified. Isnt?
Can we just trigger the modal on success on API call then?
There was a problem hiding this comment.
Yeap but the modal will be displayed on personal-details-page, so when we check for verified: 1 api call this modal will show up everytime isn't 🤔 I was thinking that when user clicks on verify button, when the API call isSuccess then we put the value in store and redirect user back to personal details then dispaly the successful modal
There was a problem hiding this comment.
Lets check with design team on this flow
utkarsha-deriv
approved these changes
May 9, 2024
amina-deriv
reviewed
May 13, 2024
...account/src/Sections/Profile/PhoneVerification/__test__/phone-number-verified-modal.spec.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
approved these changes
May 13, 2024
suisin-deriv
merged commit 43cb445
into
suisin/utkarsha/UPM819/phone_verification_flow
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add success modal for phone number verification
Screenshots: