Add the chess plugin which leverages stockfish #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaganchandan
force-pushed
the
chess
branch
2 times, most recently
from
ca8ceb5
to
91376fc
Compare
gaganchandan
changed the title
pnhofmann
reviewed
May 14, 2023
| from stockfish import Stockfish | ||
|
|
||
|
|
||
| @plugin('chess') |
There was a problem hiding this comment.
Suggested change
| @plugin('chess') | |
| @require(native="stockfish") | |
| @plugin('chess') |
You can even declare in the plugin, that stockfish binary is required ;)
pnhofmann
reviewed
May 14, 2023
|
|
||
|
|
||
| @plugin('chess') | ||
| class Chess(): |
There was a problem hiding this comment.
Maybe add an example of usage in the documentation.
Like:
"""
Docu
"""
pnhofmann
reviewed
May 14, 2023
| fen = jarvis.input("FEN: ") | ||
| if (fish.is_fen_valid(fen)): | ||
| fish.set_fen_position(fen) | ||
| jarvis.say(fish.get_best_move()) |
There was a problem hiding this comment.
You should catch ValueError at this line
Moves: a2
['a2']
Some error occurred, please open an issue on github!
Here is error:
Traceback (most recent call last):
File "/data/git/Jarvis/jarviscli/CmdInterpreter.py", line 286, in try_do
do(self, s)
File "/data/git/Jarvis/jarviscli/plugin.py", line 208, in run
self._backend[0](jarvis.get_api(), s)
File "/data/git/Jarvis/jarviscli/plugins/chess.py", line 20, in __call__
fish.set_position(moves.split())
File "/home/phil/git/Jarvis/env/lib/python3.8/site-packages/stockfish/models.py", line 222, in set_position
self.make_moves_from_current_position(moves)
File "/home/phil/git/Jarvis/env/lib/python3.8/site-packages/stockfish/models.py", line 238, in make_moves_from_current_position
raise ValueError(f"Cannot make move: {move}")
ValueError: Cannot make move: a2
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new plugin named
chessto generate best moves using stockfish.Note: It requires a
stockfishbinary to be present in the user'sPATH.