Fix the cryptotracker plugin #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to Binance API: To enhance the reliability and accuracy of cryptocurrency tracking, I have migrated the plugin to use the Binance API. Use of USDT: With the transition to the Binance API, we are kind of forced to use USDT (Tether) as the base trading pair for tracking cryptocurrencies. JSON Structure Update: As a result of switching to the Binance API, the JSON data structure received from the API has undergone some modifications. These changes have been incorporated into the code.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Jarvis Team,
I saw the cryptotracker stopped working, so I switched the defunct API and built a solution using Binance's API. This pull request aims to address the issue by implementing the following changes:
API Replacement: I've replaced the outdated API with Binance's API.
Code Refactoring: I have refactored the code to ensure it seamlessly integrates with Binance's API endpoints. This includes modifying the request and calling the data to match the new API structure.
Switch to USDT: To address limitations I've made USDT (Tether) the default USD pairing for the cryptotracker. This change was necessary due to Binance not having any USD pairs.