Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Tennis Plugin to project #1139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lux-Zhang
Copy link

Description:
In this Pull Request, I added a new Tennis Plugin to the project. This add-on allows users to access current ATP and WTA rankings, as well as past Grand Slam titles.

Change details:
In jarviscli/plugins/tennis.py

  1. Added TennisDataFetcher class:
    This class is responsible for obtaining tennis-related data from different data sources.
    The fetch_rankings method is provided to get the current ATP or WTA rankings.
    The fetch_grand_slam_winners method is provided to retrieve past Grand Slam winners.

  2. Added TennisPlugin class:
    This class is a plug-in that allows users to select the tennis-related data they want to obtain.
    Users can choose to get the current ATP or WTA rankings, or they can choose to get past Grand Slam titles.

  3. Code optimization and improvements:
    Optimized the structure of the code to make it clearer and easier to maintain.
    Added error handling to the fetch_grand_slam_winners method to ensure error conditions are handled correctly when fetching data.

Instructions:

Users can launch the plugin by entering the tennis command through Jarvis, and then follow the prompts to select the type of data they want to obtain.

Example:

    Choose one of these options:
    1. Current ATP rankings
    2. Current WTA rankings
    3. Past Grand Slam winners for ATP
    4. Past Grand Slam winners for WTA

After the user enters the corresponding numerical selection, the plugin displays the corresponding tennis data.

Conclusion:
This new Tennis Plugin adds valuable functionality to the project, allowing users to easily obtain tennis-related data. Hopefully this improvement will be merged into the master branch.

@Lux-Zhang
Copy link
Author

Hello! I'm a newbie to open source, so I'm not sure if I fully meet all the standards and guidelines. Thank you very much for giving me this opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant