Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Chart Interaction #57

Merged
merged 3 commits into from
May 31, 2024

Conversation

kashiken
Copy link
Contributor

Thank you for the recent update regarding chart selection.
That update is very useful for me to investigate the data in detail.
Let me introduce some small ideas to improve the interaction a little more.

Purpose of Change

This pull request makes the interaction with charts more flexible.

Changes

  • User can select the time range or the value range independently by pressing the Ctrl key or the Shift key, respectively.
  • User can decide whether to start playing on seek or not.

Tests

  • I've confirmed the changes visually and tested UI operations as well.
  • Some tests have been modified to test new settings and other related changes.
  • The changes conform to all existing tests.

Copy link
Owner

@sukumo28 sukumo28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!!
I will merge it.

src/webview/services/playerService.ts Show resolved Hide resolved
@sukumo28 sukumo28 merged commit ec3b348 into sukumo28:main May 31, 2024
@kashiken kashiken deleted the feature-improve-interaction branch June 16, 2024 13:38
@kashiken kashiken mentioned this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants