Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix spectrogram selection #60

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

kashiken
Copy link
Contributor

This PR fixes the problem where frequency range selection does not work correctly for frequency scales other than linear.

Changes

  • Fix frequency range selection to work with the frequency scale other than linear.

Tests

  • I've tested the UI operations.
  • The changes conform to all existing tests.

Copy link

The CI checks failed. Please review the errors and push fixes.

Copy link

@kashiken The CI checks failed. Please review the errors and push fixes.

@sukumo28
Copy link
Owner

@kashiken
Hi, we have introduced CI to our project.
If a PR does not pass lint, format, or test, a bot will point it out, so please fix it.

Copy link

@kashiken The CI checks failed. Please review the errors and push fixes.

Copy link

The CI checks passed.

@kashiken
Copy link
Contributor Author

@sukumo28 got it. I've already fixed the code and confirmed it passes the rules. thanks!

@sukumo28 sukumo28 merged commit 056a350 into sukumo28:main Jun 20, 2024
4 checks passed
@kashiken kashiken deleted the bugfix-spectrogram-selection branch June 20, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants