Move specs down into dor_repo directory

RSpec/FilePath was complaining about our spec files not matching the module namespace. This commit pushes the specs into the directory that RSpec/FilePath and RSpec/SpecFilePathFormat are expecting. It's not exactly clear what is going on with the rules, but this seems like the easiest way to not continue dancing around with the errors. rubocop/rubocop-rspec#1717
sul-dlss · Sep 25, 2023 · 6380f9b · 6380f9b
1 parent a4f62de
commit 6380f9b
Show file tree

Hide file tree

Showing 22 changed files with 20 additions and 20 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -304,6 +304,6 @@ RSpec/Eq: # new in 2.24
 RSpec/MetadataStyle: # new in 2.24
   Enabled: true
 RSpec/SpecFilePathFormat: # new in 2.24
-  Enabled: false  # NOTE: we made a spec path shorter
+  Enabled: true
 RSpec/SpecFilePathSuffix: # new in 2.24
   Enabled: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -60,48 +60,48 @@ Metrics/PerceivedComplexity:
 # Offense count: 5
 RSpec/AnyInstance:
   Exclude:
-    - 'spec/robots/assembly/jp2_create_spec.rb'
+    - 'spec/robots/dor_repo/assembly/jp2_create_spec.rb'
 
 # Offense count: 4
 # Configuration parameters: Max, CountAsOne.
 RSpec/ExampleLength:
   Exclude:
-    - 'spec/robots/assembly/checksum_compute_spec.rb'
-    - 'spec/robots/assembly/exif_collect_spec.rb'
-    - 'spec/robots/assembly/jp2_create_spec.rb'
+    - 'spec/robots/dor_repo/assembly/checksum_compute_spec.rb'
+    - 'spec/robots/dor_repo/assembly/exif_collect_spec.rb'
+    - 'spec/robots/dor_repo/assembly/jp2_create_spec.rb'
 
 # Offense count: 19
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   Exclude:
-    - 'spec/robots/assembly/checksum_compute_spec.rb'
-    - 'spec/robots/assembly/content_metadata_create_spec.rb'
-    - 'spec/robots/assembly/exif_collect_spec.rb'
-    - 'spec/robots/assembly/jp2_create_spec.rb'
-    - 'spec/robots/release/release_members_spec.rb'
+    - 'spec/robots/dor_repo/assembly/checksum_compute_spec.rb'
+    - 'spec/robots/dor_repo/assembly/content_metadata_create_spec.rb'
+    - 'spec/robots/dor_repo/assembly/exif_collect_spec.rb'
+    - 'spec/robots/dor_repo/assembly/jp2_create_spec.rb'
+    - 'spec/robots/dor_repo/release/release_members_spec.rb'
 
 # Offense count: 66
 # Configuration parameters: AllowSubject, Max.
 RSpec/MultipleMemoizedHelpers:
   Exclude:
     - 'spec/lib/dor/assembly/content_metadata_from_stub/structural_builder_spec.rb'
     - 'spec/lib/preserved_file_uris_spec.rb'
-    - 'spec/robots/accession/end_accession_spec.rb'
-    - 'spec/robots/accession/shelve_spec.rb'
-    - 'spec/robots/accession/technical_metadata_spec.rb'
-    - 'spec/robots/assembly/accessioning_initiate_spec.rb'
-    - 'spec/robots/assembly/checksum_compute_spec.rb'
-    - 'spec/robots/assembly/content_metadata_create_spec.rb'
-    - 'spec/robots/assembly/exif_collect_spec.rb'
-    - 'spec/robots/assembly/jp2_create_spec.rb'
-    - 'spec/robots/release/release_members_spec.rb'
+    - 'spec/robots/dor_repo/accession/end_accession_spec.rb'
+    - 'spec/robots/dor_repo/accession/shelve_spec.rb'
+    - 'spec/robots/dor_repo/accession/technical_metadata_spec.rb'
+    - 'spec/robots/dor_repo/assembly/accessioning_initiate_spec.rb'
+    - 'spec/robots/dor_repo/assembly/checksum_compute_spec.rb'
+    - 'spec/robots/dor_repo/assembly/content_metadata_create_spec.rb'
+    - 'spec/robots/dor_repo/assembly/exif_collect_spec.rb'
+    - 'spec/robots/dor_repo/assembly/jp2_create_spec.rb'
+    - 'spec/robots/dor_repo/release/release_members_spec.rb'
 
 # Offense count: 1
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
-    - 'spec/robots/assembly/exif_collect_spec.rb'
+    - 'spec/robots/dor_repo/assembly/exif_collect_spec.rb'
 
 # Offense count: 11
 # Configuration parameters: AllowedConstants.

diff --git a/...robots/accession/content_metadata_spec.rb → ...r_repo/accession/content_metadata_spec.rb b/...robots/accession/content_metadata_spec.rb → ...r_repo/accession/content_metadata_spec.rb
diff --git a/...ts/accession/descriptive_metadata_spec.rb → ...po/accession/descriptive_metadata_spec.rb b/...ts/accession/descriptive_metadata_spec.rb → ...po/accession/descriptive_metadata_spec.rb
diff --git a/spec/robots/accession/end_accession_spec.rb → .../dor_repo/accession/end_accession_spec.rb b/spec/robots/accession/end_accession_spec.rb → .../dor_repo/accession/end_accession_spec.rb
diff --git a/spec/robots/accession/publish_spec.rb → ...robots/dor_repo/accession/publish_spec.rb b/spec/robots/accession/publish_spec.rb → ...robots/dor_repo/accession/publish_spec.rb
diff --git a/.../robots/accession/reset_workspace_spec.rb → ...or_repo/accession/reset_workspace_spec.rb b/.../robots/accession/reset_workspace_spec.rb → ...or_repo/accession/reset_workspace_spec.rb
diff --git a/...ots/accession/sdr_ingest_transfer_spec.rb → ...epo/accession/sdr_ingest_transfer_spec.rb b/...ots/accession/sdr_ingest_transfer_spec.rb → ...epo/accession/sdr_ingest_transfer_spec.rb
diff --git a/spec/robots/accession/shelve_spec.rb → .../robots/dor_repo/accession/shelve_spec.rb b/spec/robots/accession/shelve_spec.rb → .../robots/dor_repo/accession/shelve_spec.rb
diff --git a/...bots/accession/technical_metadata_spec.rb → ...repo/accession/technical_metadata_spec.rb b/...bots/accession/technical_metadata_spec.rb → ...repo/accession/technical_metadata_spec.rb
diff --git a/spec/robots/accession/update_doi_spec.rb → ...ots/dor_repo/accession/update_doi_spec.rb b/spec/robots/accession/update_doi_spec.rb → ...ots/dor_repo/accession/update_doi_spec.rb
diff --git a/...obots/accession/update_orcid_work_spec.rb → ..._repo/accession/update_orcid_work_spec.rb b/...obots/accession/update_orcid_work_spec.rb → ..._repo/accession/update_orcid_work_spec.rb
diff --git a/...ts/assembly/accessioning_initiate_spec.rb → ...po/assembly/accessioning_initiate_spec.rb b/...ts/assembly/accessioning_initiate_spec.rb → ...po/assembly/accessioning_initiate_spec.rb
diff --git a/.../robots/assembly/checksum_compute_spec.rb → ...or_repo/assembly/checksum_compute_spec.rb b/.../robots/assembly/checksum_compute_spec.rb → ...or_repo/assembly/checksum_compute_spec.rb
diff --git a/.../assembly/content_metadata_create_spec.rb → .../assembly/content_metadata_create_spec.rb b/.../assembly/content_metadata_create_spec.rb → .../assembly/content_metadata_create_spec.rb
diff --git a/spec/robots/assembly/exif_collect_spec.rb → ...ts/dor_repo/assembly/exif_collect_spec.rb b/spec/robots/assembly/exif_collect_spec.rb → ...ts/dor_repo/assembly/exif_collect_spec.rb
diff --git a/spec/robots/assembly/jp2_create_spec.rb → ...bots/dor_repo/assembly/jp2_create_spec.rb b/spec/robots/assembly/jp2_create_spec.rb → ...bots/dor_repo/assembly/jp2_create_spec.rb
diff --git a/spec/robots/dissemination/cleanup_spec.rb → ...ts/dor_repo/dissemination/cleanup_spec.rb b/spec/robots/dissemination/cleanup_spec.rb → ...ts/dor_repo/dissemination/cleanup_spec.rb
diff --git a/spec/robots/goobi_notify_spec.rb → ...obots/dor_repo/goobi/goobi_notify_spec.rb b/spec/robots/goobi_notify_spec.rb → ...obots/dor_repo/goobi/goobi_notify_spec.rb
diff --git a/spec/robots/release/release_members_spec.rb → .../dor_repo/release/release_members_spec.rb b/spec/robots/release/release_members_spec.rb → .../dor_repo/release/release_members_spec.rb
diff --git a/spec/robots/release/release_publish_spec.rb → .../dor_repo/release/release_publish_spec.rb b/spec/robots/release/release_publish_spec.rb → .../dor_repo/release/release_publish_spec.rb
diff --git a/spec/robots/release/update_marc_spec.rb → ...bots/dor_repo/release/update_marc_spec.rb b/spec/robots/release/update_marc_spec.rb → ...bots/dor_repo/release/update_marc_spec.rb