Fix initializing of webspaces with same role name #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
alexander-schranz
pushed a commit
that referenced
this pull request
May 17, 2019
Flush after Webspace was initialized in InitCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adjusts the
InitCommandto call flush on theEntityManagerafter initializing a webspace.Why?
Because this way it is possible to configure the same role for multiple Webspaces. Otherwise the created role is not flushed and therefore created again during the initialization of the second Webspace. This leads to a
Doctrine\DBAL\Exception\UniqueConstraintViolationException.