-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Symfony 5.4 compatibility of DisabledCsrfTokenManager #307
Conversation
Looks for me correctly for 5.4 but it seems to install a newer version. So I think our error is that we forget to define the dependency to csrf token package. |
Can you add |
That seems to fix it, installed 6.0 without defining the version in composer. |
@eekes Thx for the report and the pull request. |
@eekes released as 2.2.1. |
What's in this PR?
Make DisabledCsrfTokenManager compatible with Symfony's CsrfTokenManagerInterface
Why?
DisabledCsrfTokenManager doesn't seem be compatible with Symfony 5.4 because of the return types that were added.
Example Usage
Simply by using a form in a Symfony 5.4 Sulu project.
BC Breaks/Deprecations
Don't think so?