Make salutation gender neutral #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
requested changes
Dec 20, 2022
Dynamic/Types/SalutationType.php
Outdated
| 'sulu_form.salutation_ms' => 'ms', | ||
| 'sulu_form.salutation_mr' => 'mr', | ||
| 'sulu_form.salutation_other' => 'other', |
There was a problem hiding this comment.
I think this is not the correct way of handling this. As a Salutation is never gender neutral. The salutation is used in Letters and something like Hello Other Alexander Schranz, is I think not the expected result.
The correct way for me would be here make sure that there is no default and no Please choose, something like No salutation or No choice / Keine auswahl should be the default value of the form, with an empty value.
There was a problem hiding this comment.
Did just now see this is the FormBundle this salutations represent Salutation of ContactBundle and so this need to be changed there first.
alexander-schranz
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add
Otheroption to salutation field and addPlease chooseplaceholder instead of automatically selectMr..Why?
To make salutation gender neutral.