Update SendingBlueEventListener to correctly send DoubleOpt-In emails #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
alexander-schranz
approved these changes
Feb 21, 2023
| ], | ||
| 'includeListIds' => ['789'], | ||
| 'templateId' => 456, | ||
| 'redirectionUrl' => 'http://localhost?subscribe=true', | ||
| 'updateEnable' => true, |
There was a problem hiding this comment.
Suggested change
| 'updateEnable' => true, | |
| 'updateEnabled' => true, |
alexander-schranz
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Explain the contents of the PR.
Why?
#348 fixed the error, but introduced an unexpected behaviour. The user was updated directly and for already registered users, no DOI email was sent by sendinblue.
This PR adds theUpdate: theupdateEnabledflag, therefore the DOI is still sent and already existing users are updated.updateEnabledflag was never send and Today SendingBlue fixed the issue.Furthermore the PR uses the normalized attributes
firstnameandlastnamefor the additional data.