Add Symfony 7 support #139
Conversation
Co-authored-by: Alexander Schranz <alexander@sulu.io>
|
I only have Sulu 2.6 in there at the moment, because otherwise the tests fail due to the change in. sulu/sulu#7238 What do you think @alexander-schranz ? Should we leave it as it is or what is the best way to go about it? |
alexander-schranz
force-pushed
the
symfony-7-support
branch
from
378dc46 to
b8f0b85
Compare
alexander-schranz
force-pushed
the
symfony-7-support
branch
from
b8f0b85 to
4454b90
Compare
alexander-schranz
force-pushed
the
symfony-7-support
branch
from
4454b90 to
fccc294
Compare
composer.json
Outdated
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "git@github.com:alexander-schranz/sulu.git" | ||
| } | ||
| ], |
There was a problem hiding this comment.
This need to be removed when sulu/sulu is merged sulu/sulu#7156:
| "repositories": [ | |
| { | |
| "type": "vcs", | |
| "url": "git@github.com:alexander-schranz/sulu.git" | |
| } | |
| ], | |
| "repositories": [ | |
| { | |
| "type": "vcs", | |
| "url": "git@github.com:alexander-schranz/sulu.git" | |
| } | |
| ], |
@TheCadien the current Symfony 7 pull request requires this so we can test the compatibility correctly. We need to remove before merging it.
alexander-schranz
force-pushed
the
symfony-7-support
branch
from
8cf8049 to
52bd36d
Compare
| - name: Install Symfony 7 dev branch # TODO remove | ||
| if: ${{ matrix.php-version == '8.2' || matrix.php-version == '8.3' }} | ||
| run: composer require sulu/sulu:"dev-feature/symfony-7-support as 2.6.3" | ||
|
|
There was a problem hiding this comment.
This will be removed when sulu/sulu#7156 is merged. Currently here to test PHP 8.2 and 8.3 tasks against Symfony 7.
alexander-schranz
force-pushed
the
symfony-7-support
branch
2 times, most recently
from
912a4ab to
b3989ef
Compare
alexander-schranz
force-pushed
the
symfony-7-support
branch
from
8747730 to
84b5bf6
Compare
composer.json
Outdated
| "symfony/console": "^4.4 || ^5.4 || ^6.3 || ^7.0", | ||
| "symfony/dotenv": "^4.4 || ^5.4 || ^6.3 || ^7.0", | ||
| "symfony/error-handler": "^4.4 || ^5.4 || ^6.3 || ^7.0", | ||
| "symfony/security-bundle": "^4.4 || ^5.4 || ^6.3 || ^7.0", |
There was a problem hiding this comment.
the security bundle did not define its dependency correctly in Symfony 6.0 to avoid mixed (framework 5.4 and security 6.0) installation of unsupported packages we force specific versions here to avoid: https://github.com/sulu/SuluHeadlessBundle/actions/runs/9448421512/job/26022383599?pr=139
There was a problem hiding this comment.
This will be fixed in sulu/sulu#7455 and so the change can may be reverted
…Bundle into symfony-7-support # Conflicts: # .github/workflows/test-application.yaml # Tests/Functional/Controller/NavigationControllerTest.php # composer.json # phpstan-baseline.neon
| }, | ||
| "require-dev": { | ||
| "coduo/php-matcher": "^5.0 || ^6.0", | ||
| "handcraftedinthealps/code-coverage-checker": "^0.2.1", | ||
| "handcraftedinthealps/zendsearch": "^2.0", | ||
| "jackalope/jackalope-doctrine-dbal": "^1.3.4", | ||
| "jackalope/jackalope-doctrine-dbal": "^1.3.4 || ^2.0", |
There was a problem hiding this comment.
@TheCadien PS: the jackalope versions need also be upgrade to support Symfony 7 else you still will get Symfony 6.4 for example for symfony/console.
|
Looks like we need to fix 8.0 and 8.1 try to make the phpcr bundle requirements more strictly: doctrine/DoctrinePHPCRBundle#404 |
Allow Symfony 7 Packages.
part of sulu/sulu#7413