[rector] make use of new config, and prepared set methods #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-rector-config
branch
from
50baba9 to
5936fd1
Compare
|
@TomasVotruba Thank you!
Sure if you have more things to suggest feel free to open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rector 1.0, you can use new config that is constantly being developed.
It makes use of named-arg configuration and keeps config slim and focused on sets :)
Goal of this PR is just to use better syntax for the same config.
I'd recommend using more of the default sets as best practise for all PHP projects. If you're up-to it, I'll send another PR.