-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/tweak stylesheet colours #47
Conversation
Looks good to me. I never really worked with the highlight dates part before but i guess is would expect that a disabled date can not be highlighted. So we can keep it that way. Disabled states don't need to be accessible compliant, i guess https://www.w3.org/TR/WCAG21/#contrast-minimum If you merge master into your branch i will merge this PR 👍 |
Ok great, thanks. Thanks for the W3 reference. Yes, I think it's fair to consider the disabled dates to be 'inactive'; they therefore can be considered 'incidental' and do not need to be accessible-compliant:
The I played around with the idea of perhaps using a light grey background for these 'edge dates', but it didn't look right. So, if you'd like us to be fully compliant, I think we should darken the text colour of the edge dates slightly to be the lightest acceptable grey for |
…e-datepicker into style/tweak-stylesheet-colours
Just had another thought - we could perhaps make the edge dates a little smaller? What do you think? |
I don't think playing with the font size is a good thing, this is oriented on the body font size. I think the way it is now with your changes it is perfectly sufficient. |
Ok, great. Let me know if there's anything else you need to me do in order for you to merge this in. Thanks. |
Grey text on a coloured background does not look good, so I've chosen a dark blue instead (
#104756
).In terms of accessibility, this is
WCAG AAA
compliant on the.highlighted
background of#44bbdd
andWCAG AA
compliant on the.selected
background of#cae5ed
for 'normal text'. See contrast checkerN.B. As things stand, the
.disabled
styles completely override any.highlighted
styles. Are you happy with this behaviour, or do you think that disabled cells that are highlighted should be distinguishable from disabled cells that are not highlighted?Also, I noticed that the
.disabled
text colour#dddddd
is not accessibility compliant on a white background. However, if you decrease the brightness enough to make it at leastWCAG AA
compliant for normal text i.e.#757575
- that just seems far too dark to my eyes for something that is supposed to be disabled. Themuted
text colour of#a3a3a3
is also not compliant. What are your thoughts on this?