Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#430 Upgrade webmock and tests #438

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

bobbrodie
Copy link
Member

Overview

The goal of this pull request is to upgrade to webmock 3.x. There are a few changes necessary to accomplish this:

  • Update webmock
  • Update how we implement authenticated calls

Notes

The number of tests reported will drop, due to what I can tell are duplicates running in v1. Looking at the examples below, you'll see that webmock v1.x was running the shared tests twice. This has been remedied.

webmock v1.x

JIRA::Resource::Comment
  it should behave like a resource
    gracefully handles non-json responses
  it should behave like a resource with a collection GET endpoint
    should get the collection
  it should behave like a resource with a singular GET endpoint
    GETs a single resource
    builds and fetches a single resource
    handles a 404
  it should behave like a resource with a DELETE endpoint
    deletes a resource
  it should behave like a resource with a POST endpoint
    saves a new resource
  it should behave like a resource with a PUT endpoint
    saves an existing component
  it should behave like a resource
    gracefully handles non-json responses
  it should behave like a resource with a collection GET endpoint
    should get the collection
  it should behave like a resource with a singular GET endpoint
    GETs a single resource
    builds and fetches a single resource
    handles a 404
  it should behave like a resource with a DELETE endpoint
    deletes a resource
  it should behave like a resource with a POST endpoint
    saves a new resource
  it should behave like a resource with a PUT endpoint
    saves an existing component

webmock v3.x

JIRA::Resource::Comment
  it should behave like a resource
    gracefully handles non-json responses
  it should behave like a resource with a collection GET endpoint
    should get the collection
  it should behave like a resource with a singular GET endpoint
    GETs a single resource
    builds and fetches a single resource
    handles a 404
  it should behave like a resource with a DELETE endpoint
    deletes a resource
  it should behave like a resource with a POST endpoint
    saves a new resource
  it should behave like a resource with a PUT endpoint
    saves an existing component

@bobbrodie bobbrodie linked an issue Apr 27, 2024 that may be closed by this pull request
@bobbrodie bobbrodie added this to the v3.0.0 milestone Apr 27, 2024
@bobbrodie bobbrodie added the Maintenance Chores, dependency updates, etc. label Apr 27, 2024
@bobbrodie bobbrodie requested a review from p-maguire April 27, 2024 05:27
@bobbrodie bobbrodie merged commit 9b09576 into sumoheavy:master Apr 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Chores, dependency updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade webmock
2 participants