Issue with other library

[Jim-bee]

Hi,
Your library works great with EastRising 1.8" display a couple of exceptions;

1. the example scroll function does not work for me.
2. Compatibility issue with MLX90393 library //From https://github.com/tedyapo/arduino-MLX90393 by Theodore Yapo.

NOTE: Both libraries work fine on their own. Please let me know if this can be fixed or maybe a work around.

Compile Errors:

n file included from /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/TFT_ILI9163C.h:135:0,
from /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:11:
/Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: error: expected identifier before numeric constant
#define CMD_NOP 0x00//Non operation
^
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: note: in expansion of macro 'CMD_NOP'
CMD_NOP = 0x00,
^
/Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: error: expected '}' before numeric constant
#define CMD_NOP 0x00//Non operation
^
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: note: in expansion of macro 'CMD_NOP'
CMD_NOP = 0x00,
^
/Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: error: expected unqualified-id before numeric constant
#define CMD_NOP 0x00//Non operation
^
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: note: in expansion of macro 'CMD_NOP'
CMD_NOP = 0x00,
^
In file included from /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:14:0:
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:65:12: error: expected unqualified-id before ')' token
MLX90393();
^
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:116:1: error: expected unqualified-id before 'private'
private:
^
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:138:3: error: expected unqualified-id before 'private'
private:
^
/Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:141:1: error: expected declaration before '}' token
};
^
exit status 1
Error compiling for board Adafruit Feather M0.

[SurenBono]

...those are compilation error...you have to debug all of those error before you can get what you want....belive me i seen a 1000 of those myself...finding out how to fix em...will take some time...and it was not my sketch either...im one of you..

…

On 5:36am, Tue, Jul 16, 2019 Jim-bee ***@***.*** wrote: Hi, Your library works great with EastRising 1.8" display a couple of exceptions; 1. the example scroll function does not work for me. 2. Compatibility issue with MLX90393 library //From https://github.com/tedyapo/arduino-MLX90393 by Theodore Yapo. NOTE: Both libraries work fine on their own. Please let me know if this can be fixed or maybe a work around. Compile Errors: n file included from /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/TFT_ILI9163C.h:135:0, from /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:11: /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: error: expected identifier before numeric constant #define CMD_NOP 0x00//Non operation ^ /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: note: in expansion of macro 'CMD_NOP' CMD_NOP = 0x00, ^ /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: error: expected '}' before numeric constant #define CMD_NOP 0x00//Non operation ^ /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: note: in expansion of macro 'CMD_NOP' CMD_NOP = 0x00, ^ /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: error: expected unqualified-id before numeric constant #define CMD_NOP 0x00//Non operation ^ /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: note: in expansion of macro 'CMD_NOP' CMD_NOP = 0x00, ^ In file included from /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:14:0: /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:65:12: error: expected unqualified-id before ')' token MLX90393(); ^ /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:116:1: error: expected unqualified-id before 'private' private: ^ /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:138:3: error: expected unqualified-id before 'private' private: ^ /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:141:1: error: expected declaration before '}' token }; ^ exit status 1 Error compiling for board Adafruit Feather M0. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#70?email_source=notifications&email_token=AK2KU565XJTKT74BJ7S3CTTP7TUWBA5CNFSM4ID3AFS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7KM74Q>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK2KU57LYYTLK2U4V5KSG33P7TUWBANCNFSM4ID3AFSQ> .

[Jim-bee]

Hello, I have received information from Ted Yapo MLX90393 library guy. He mentioned the following about your ILI90393 library in his reply to this issue. "The other library should not pollute the global namespace with #defines like CMD_NOP. If they used scoped enums like this one does, this kind of error would not happen. “ I have proven this out that if I comment out your //#define CMD_NOP = 0x00 in your .h file then everything complies fine. Will this cause any issues with your library or is this a good work around? Please consider his recommendation to make your library more compatible with the other libraries out there. Best Regards, Jim

…

On Jul 15, 2019, at 5:07 PM, SurenBono ***@***.***> wrote: ...those are compilation error...you have to debug all of those error before you can get what you want....belive me i seen a 1000 of those myself...finding out how to fix em...will take some time...and it was not my sketch either...im one of you.. On 5:36am, Tue, Jul 16, 2019 Jim-bee ***@***.*** wrote: > Hi, > Your library works great with EastRising 1.8" display a couple of > exceptions; > > 1. the example scroll function does not work for me. > 2. Compatibility issue with MLX90393 library //From > https://github.com/tedyapo/arduino-MLX90393 by Theodore Yapo. > > NOTE: Both libraries work fine on their own. Please let me know if this > can be fixed or maybe a work around. > > Compile Errors: > > n file included from > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/TFT_ILI9163C.h:135:0, > from /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:11: > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: > error: expected identifier before numeric constant > #define CMD_NOP 0x00//Non operation > ^ > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: > note: in expansion of macro 'CMD_NOP' > CMD_NOP = 0x00, > ^ > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: > error: expected '}' before numeric constant > #define CMD_NOP 0x00//Non operation > ^ > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: > note: in expansion of macro 'CMD_NOP' > CMD_NOP = 0x00, > ^ > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: > error: expected unqualified-id before numeric constant > #define CMD_NOP 0x00//Non operation > ^ > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: > note: in expansion of macro 'CMD_NOP' > CMD_NOP = 0x00, > ^ > In file included from > /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:14:0: > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:65:12: > error: expected unqualified-id before ')' token > MLX90393(); > ^ > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:116:1: > error: expected unqualified-id before 'private' > private: > ^ > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:138:3: > error: expected unqualified-id before 'private' > private: > ^ > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:141:1: > error: expected declaration before '}' token > }; > ^ > exit status 1 > Error compiling for board Adafruit Feather M0. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#70?email_source=notifications&email_token=AK2KU565XJTKT74BJ7S3CTTP7TUWBA5CNFSM4ID3AFS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7KM74Q>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AK2KU57LYYTLK2U4V5KSG33P7TUWBANCNFSM4ID3AFSQ> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#70?email_source=notifications&email_token=AKVJBA7R5FXW5RXZUORMRGDP7T7LTA5CNFSM4ID3AFS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7G4DI#issuecomment-511602189>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKVJBA2NPU5MNPX6LCV3CLTP7T7LTANCNFSM4ID3AFSQ>.

[SurenBono]

I did not write any drivers or know how to for ILI90393.... must be a mis-info...i was there regarding offset noise err on ILI9163C

…

On 10:58pm, Wed, Jul 17, 2019 Jim-bee ***@***.*** wrote: Hello, I have received information from Ted Yapo MLX90393 library guy. He mentioned the following about your ILI90393 library in his reply to this issue. "The other library should not pollute the global namespace with #defines like CMD_NOP. If they used scoped enums like this one does, this kind of error would not happen. “ I have proven this out that if I comment out your //#define CMD_NOP = 0x00 in your .h file then everything complies fine. Will this cause any issues with your library or is this a good work around? Please consider his recommendation to make your library more compatible with the other libraries out there. Best Regards, Jim > On Jul 15, 2019, at 5:07 PM, SurenBono ***@***.***> wrote: > > ...those are compilation error...you have to debug all of those error > before you can get what you want....belive me i seen a 1000 of those > myself...finding out how to fix em...will take some time...and it was not > my sketch either...im one of you.. > > On 5:36am, Tue, Jul 16, 2019 Jim-bee ***@***.*** wrote: > > > Hi, > > Your library works great with EastRising 1.8" display a couple of > > exceptions; > > > > 1. the example scroll function does not work for me. > > 2. Compatibility issue with MLX90393 library //From > > https://github.com/tedyapo/arduino-MLX90393 by Theodore Yapo. > > > > NOTE: Both libraries work fine on their own. Please let me know if this > > can be fixed or maybe a work around. > > > > Compile Errors: > > > > n file included from > > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/TFT_ILI9163C.h:135:0, > > from /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:11: > > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: > > error: expected identifier before numeric constant > > #define CMD_NOP 0x00//Non operation > > ^ > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: > > note: in expansion of macro 'CMD_NOP' > > CMD_NOP = 0x00, > > ^ > > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: > > error: expected '}' before numeric constant > > #define CMD_NOP 0x00//Non operation > > ^ > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: > > note: in expansion of macro 'CMD_NOP' > > CMD_NOP = 0x00, > > ^ > > /Users/JimD/Documents/Arduino/libraries/TFT_ILI9163C-master/_settings/TFT_ILI9163C_registers.h:6:22: > > error: expected unqualified-id before numeric constant > > #define CMD_NOP 0x00//Non operation > > ^ > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:38:5: > > note: in expansion of macro 'CMD_NOP' > > CMD_NOP = 0x00, > > ^ > > In file included from > > /Users/JimD/Documents/Arduino/RewinderTS/RewinderTS.ino:14:0: > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:65:12: > > error: expected unqualified-id before ')' token > > MLX90393(); > > ^ > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:116:1: > > error: expected unqualified-id before 'private' > > private: > > ^ > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:138:3: > > error: expected unqualified-id before 'private' > > private: > > ^ > > /Users/JimD/Documents/Arduino/libraries/arduino-MLX90393-master/MLX90393.h:141:1: > > error: expected declaration before '}' token > > }; > > ^ > > exit status 1 > > Error compiling for board Adafruit Feather M0. > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > < #70?email_source=notifications&email_token=AK2KU565XJTKT74BJ7S3CTTP7TUWBA5CNFSM4ID3AFS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7KM74Q >, > > or mute the thread > > < https://github.com/notifications/unsubscribe-auth/AK2KU57LYYTLK2U4V5KSG33P7TUWBANCNFSM4ID3AFSQ > > > . > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub < #70?email_source=notifications&email_token=AKVJBA7R5FXW5RXZUORMRGDP7T7LTA5CNFSM4ID3AFS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7G4DI#issuecomment-511602189>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AKVJBA2NPU5MNPX6LCV3CLTP7T7LTANCNFSM4ID3AFSQ >. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#70?email_source=notifications&email_token=AK2KU52V65473P54MEPZ2FTP74XRXA5CNFSM4ID3AFS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2EPS2I#issuecomment-512293225>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK2KU5YAMNWP4XR3IUQ73QDP74XRXANCNFSM4ID3AFSQ> .