fix for non modal dialogs

sumup-oss · Nov 29, 2024 · 7b1cc74 · 7b1cc74
1 parent 0e0b1f0
commit 7b1cc74
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/circuit-ui/components/Dialog/Dialog.tsx b/packages/circuit-ui/components/Dialog/Dialog.tsx
@@ -154,7 +154,7 @@ export const Dialog = forwardRef<HTMLDialogElement, DialogProps>(
         if (!dialogElement.open) {
           if (isModal) {
             dialogElement.showModal();
-            if (!hasNativeDialog) {
+            if (!hasNativeDialog && isModal) {
               // use the polyfill backdrop
               (dialogElement.nextSibling as HTMLDivElement).classList.add(
                 classes['backdrop-visible'],
@@ -183,9 +183,9 @@ export const Dialog = forwardRef<HTMLDialogElement, DialogProps>(
     }, [open, isModal, handleDialogClose, hasNativeDialog]);
 
     const onDialogClick = (
-      e: ClickEvent<HTMLDialogElement> | ClickEvent<HTMLDivElement>,
+      event: ClickEvent<HTMLDialogElement> | ClickEvent<HTMLDivElement>,
     ) => {
-      if (isModal && e.target === e.currentTarget) {
+      if (isModal && event.target === event.currentTarget) {
         handleDialogClose();
       }
     };
@@ -196,7 +196,7 @@ export const Dialog = forwardRef<HTMLDialogElement, DialogProps>(
         return;
       }
       dialogElement.classList.remove(classes.show);
-      if (!hasNativeDialog) {
+      if (!hasNativeDialog && isModal) {
         (dialogElement.nextSibling as HTMLDivElement).classList.remove(
           classes['backdrop-visible'],
         );