Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation hint icon alignment #2160

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

connor-baer
Copy link
Member

Purpose

The validation icon should be center-aligned with the text. The text shouldn't wrap around the icon.

Before

Screenshot 2023-06-22 at 20 26 28

After

Screenshot 2023-06-22 at 20 30 19

Approach and changes

  • Use flexbox to align the icon

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jun 22, 2023
@connor-baer connor-baer requested a review from a team as a code owner June 22, 2023 19:31
@connor-baer connor-baer requested review from tareqlol and removed request for a team June 22, 2023 19:31
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 7cc620e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Jun 22, 2023 7:31pm

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2160 (7cc620e) into main (0eebf6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2160   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         171      171           
  Lines        3607     3607           
  Branches     1270     1270           
=======================================
  Hits         3322     3322           
  Misses        264      264           
  Partials       21       21           
Impacted Files Coverage Δ
...t-ui/components/FieldAtoms/FieldValidationHint.tsx 94.59% <ø> (ø)

@connor-baer connor-baer enabled auto-merge (squash) June 22, 2023 19:34
@connor-baer connor-baer merged commit 7774d60 into main Jun 23, 2023
10 checks passed
@connor-baer connor-baer deleted the bugfix/validation-hint branch June 23, 2023 07:51
@connor-baer connor-baer mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants