-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(circuit-ui): Add experimental ColorInput component #2655
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ae78968 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f88ccc8
to
4252f4a
Compare
4252f4a
to
8777b4d
Compare
5f35788
to
ca001e0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
==========================================
+ Coverage 86.59% 86.63% +0.03%
==========================================
Files 209 210 +1
Lines 11885 12000 +115
Branches 1500 1506 +6
==========================================
+ Hits 10292 10396 +104
- Misses 1540 1551 +11
Partials 53 53
|
ca001e0
to
b83cf5e
Compare
b83cf5e
to
7a2f217
Compare
7a2f217
to
4730d9d
Compare
2920340
to
b6fb14b
Compare
b6fb14b
to
2d056bd
Compare
a235be9
to
897e526
Compare
897e526
to
97180c3
Compare
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Importing the same CSS Module multiple times duplicates the styles and can cause specificity issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go as an experimental component. We'll need to iterate on the documentation and accessibility.
[Work in progress]
Add experimental
ColorInput
component.Purpose
Describe what you are trying to accomplish
Approach and changes
Describe how you solved the problem
Definition of done