fix(circuit-ui): DSYS-829 | tweak inputs size #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba481ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -27 B (0%) Total Size: 640 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2724 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 210 210
Lines 12471 12471
Branches 1507 1507
=======================================
Hits 10884 10884
Misses 1537 1537
Partials 50 50 |
connor-baer
reviewed
Oct 17, 2024
sirineJ
force-pushed
the
fix/DSYS-829/input-height
branch
from
476fddb
to
2c5245b
Compare
sirineJ
force-pushed
the
fix/DSYS-829/input-height
branch
from
2c5245b
to
ba481ef
Compare
connor-baer
approved these changes
Oct 17, 2024
| .base:active { | ||
| box-shadow: 0 0 0 1px var(--cui-border-accent); | ||
| border: 1px solid var(--cui-border-accent); | ||
| box-shadow: inset 0 0 0 1px var(--cui-border-accent); |
There was a problem hiding this comment.
Fantastic idea to use an inset box shadow to avoid any overflow! 💡🤩
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-829
Purpose
Following the typography revamp, changes in line-height to text inside the some input components caused them to change height from 48px to 46px, causing a 2px reduction in their height. This slight difference might cause some alignement issues when theses components are placed next to other components who kept their original size.
Approach and changes
Definition of done