Add SkipLink component and integrate with navigation components #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9b19c58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2780 +/- ##
==========================================
- Coverage 87.28% 87.28% -0.01%
==========================================
Files 214 215 +1
Lines 12617 12640 +23
Branches 1691 1694 +3
==========================================
+ Hits 11013 11033 +20
- Misses 1551 1554 +3
Partials 53 53
|
|
Size Change: +452 B (+0.07%) Total Size: 640 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
feat/DSYS-444/skip-nav-link
branch
from
c3a6805
to
0575d3a
Compare
connor-baer
requested changes
Nov 15, 2024
There was a problem hiding this comment.
I was skeptical about integrating the skip link directly into the navigation components, but now I see that this adds very little code and ensures that the skip link is positioned properly. Nice!
I left suggestions to improve the styling and restructure the docs to match the other components.
packages/circuit-ui/components/TopNavigation/TopNavigation.spec.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/SideNavigation/SideNavigation.spec.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/SideNavigation/SideNavigation.spec.tsx
Outdated
Show resolved
Hide resolved
…d SideNavigation components.
sirineJ
force-pushed
the
feat/DSYS-444/skip-nav-link
branch
from
eb3b842
to
9101cb3
Compare
connor-baer
reviewed
Nov 18, 2024
| @@ -111,6 +111,8 @@ export const baseArgs: TopNavigationProps = { | |||
| onClick: action('Shop'), | |||
| }, | |||
| ], | |||
| skipNavigationHref: '#main-content', | |||
There was a problem hiding this comment.
This element doesn't exist, does it?
packages/circuit-ui/components/SideNavigation/SideNavigation.stories.tsx
Show resolved
Hide resolved
sirineJ
force-pushed
the
feat/DSYS-444/skip-nav-link
branch
from
445ebcd
to
18000cb
Compare
sirineJ
force-pushed
the
feat/DSYS-444/skip-nav-link
branch
from
18000cb
to
9b19c58
Compare
connor-baer
changed the title
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-444
Purpose
Make a skip link component available to bypass blocks for screen reader and keyboard users
Approach and changes
Definition of done