-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): enhance Modal and migrate to TypeScript #610
Conversation
feature/modal-hook
feature/modal-hook
feature/modal-hook
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/3szef5edn |
Codecov Report
@@ Coverage Diff @@
## beta #610 +/- ##
==========================================
- Coverage 93.93% 93.87% -0.07%
==========================================
Files 133 134 +1
Lines 2144 2154 +10
Branches 639 640 +1
==========================================
+ Hits 2014 2022 +8
- Misses 106 108 +2
Partials 24 24
|
feature/modal-hook
🎉 This PR is included in version 2.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Supercedes #415, #483.
Approach and changes
useModal
hookModalFooter
sticky on mobile for when the content exceeds the modal heightDefinition of done