Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): enhance Modal and migrate to TypeScript #610

Merged
merged 7 commits into from
Jun 11, 2020

Conversation

connor-baer
Copy link
Member

Supercedes #415, #483.

Approach and changes

  • migrate Modal and subcomponents to TypeScript
  • add useModal hook
  • make ModalFooter sticky on mobile for when the content exceeds the modal height

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the feature A new feature or enhancement label Jun 8, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jun 8, 2020
@vercel
Copy link

vercel bot commented Jun 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/3szef5edn
✅ Preview: https://circuit-ui-git-feature-modal-hook.sumup-oss.now.sh

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #610 into beta will decrease coverage by 0.06%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #610      +/-   ##
==========================================
- Coverage   93.93%   93.87%   -0.07%     
==========================================
  Files         133      134       +1     
  Lines        2144     2154      +10     
  Branches      639      640       +1     
==========================================
+ Hits         2014     2022       +8     
- Misses        106      108       +2     
  Partials       24       24              
Impacted Files Coverage Δ
src/components/Button/Button.tsx 100.00% <ø> (ø)
src/util/type-check.ts 83.33% <80.00%> (ø)
src/components/Modal/Modal.tsx 93.10% <93.10%> (ø)
src/components/Modal/ModalContext.tsx 93.33% <93.33%> (ø)
src/components/Card/components/Footer/Footer.js 100.00% <100.00%> (ø)
...nents/Modal/components/ModalFooter/ModalFooter.tsx 100.00% <100.00%> (ø)
...nents/Modal/components/ModalHeader/ModalHeader.tsx 100.00% <100.00%> (ø)
...nts/Modal/components/ModalWrapper/ModalWrapper.tsx 100.00% <100.00%> (ø)
... and 1 more

@connor-baer connor-baer requested a review from hleote June 8, 2020 21:54
@connor-baer connor-baer changed the title feat(components): tweak and migrate Modal to TypeScript feat(components): enhance Modal and migrate to TypeScript Jun 8, 2020
@herberthenrique herberthenrique mentioned this pull request Jun 9, 2020
49 tasks
src/components/Modal/Modal.spec.tsx Show resolved Hide resolved
src/components/Modal/Modal.spec.tsx Show resolved Hide resolved
@connor-baer connor-baer merged commit 1668614 into beta Jun 11, 2020
@connor-baer connor-baer deleted the feature/modal-hook branch June 11, 2020 15:04
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants