-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): migrate Spacing to TypeScript #630
Conversation
feature/typescript-spacing
feature/typescript-spacing
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/a5l9bs5x1 |
Codecov Report
@@ Coverage Diff @@
## beta #630 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 133 133
Lines 2155 2155
Branches 596 596
=======================================
Hits 2022 2022
Misses 111 111
Partials 22 22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, your first PR to Circuit UI! 👏
Aside from the two minor issues I flagged, this is looking great!
feature/typescript-spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
🎉 This PR is included in version 2.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Addresses #516.
Purpose
Addresses #516.
Approach and changes
migrate Spacing to TypeScript
Definition of done