Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): migrate Spacing to TypeScript #630

Merged
merged 5 commits into from
Jul 2, 2020

Conversation

amelako
Copy link
Contributor

@amelako amelako commented Jul 1, 2020

Addresses #516.

Purpose

Addresses #516.

Approach and changes

migrate Spacing to TypeScript

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@vercel
Copy link

vercel bot commented Jul 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/a5l9bs5x1
✅ Preview: https://circuit-ui-git-feature-typescript-spacing.sumup-oss.vercel.app

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #630 into beta will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #630   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files         133      133           
  Lines        2155     2155           
  Branches      596      596           
=======================================
  Hits         2022     2022           
  Misses        111      111           
  Partials       22       22           
Impacted Files Coverage Δ
src/components/Spacing/Spacing.tsx 100.00% <100.00%> (ø)

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, your first PR to Circuit UI! 👏

Aside from the two minor issues I flagged, this is looking great!

src/components/Spacing/Spacing.story.tsx Outdated Show resolved Hide resolved
src/components/Spacing/Spacing.tsx Outdated Show resolved Hide resolved
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connor-baer connor-baer merged commit 752d780 into beta Jul 2, 2020
@connor-baer connor-baer deleted the feature/typescript-spacing branch July 2, 2020 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2020

🎉 This PR is included in version 2.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants