-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Popover menu component #944
Conversation
🦋 Changeset detectedLatest commit: fcad3d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/BLrof6J89BDx9L52aGgBTwwZ9EFh |
Hey @amelako, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🙌
Just a high-level initial review, let me know if you have questions or need support 🙂 I'll also take a look at the docs and stories after they're ready for review
(also a small note: this PR should target |
Codecov Report
@@ Coverage Diff @@
## next #944 +/- ##
==========================================
- Coverage 91.67% 91.62% -0.05%
==========================================
Files 165 164 -1
Lines 3063 3069 +6
Branches 754 752 -2
==========================================
+ Hits 2808 2812 +4
Misses 227 227
- Partials 28 30 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐩
Addresses #723.
Purpose
Introduces the new Popover component.
Popover menus are a common pattern to display a list of subsequent action options, when interacting with an actionable component.
Approach and changes
Note: some things have been left out of this PR's scope and will be addressed in later versions:
Definition of done