Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable react/no-unknown-property rule for Emotion.js' css prop #846

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

connor-baer
Copy link
Member

Addresses #issue-number.

Purpose

The react/no-unknown-property rule from eslint-plugin-react will produce an error if the css prop is passed to a DOM element. This violation of the rule can be safely ignored because @emotion/react intercepts the css prop before it is applied to the DOM element.

From the Emotion.js docs

Approach and changes

  • Disable the react/no-unknown-property rule for Emotion.js' css prop

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner April 3, 2023 12:05
@connor-baer connor-baer requested review from robinmetral and removed request for a team April 3, 2023 12:05
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: 5aa6869

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #846 (5aa6869) into next (2197f0e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #846   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files          18       18           
  Lines         383      383           
  Branches       64       64           
=======================================
  Hits          263      263           
  Misses        111      111           
  Partials        9        9           
Impacted Files Coverage Δ
src/configs/eslint/config.ts 95.08% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@connor-baer connor-baer merged commit 5c4d73c into next Apr 3, 2023
@connor-baer connor-baer deleted the bugfix/unknown-prop-css branch April 3, 2023 12:06
@connor-baer connor-baer mentioned this pull request Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant