Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak linting rules #854

Merged
merged 5 commits into from
Apr 16, 2023
Merged

Tweak linting rules #854

merged 5 commits into from
Apr 16, 2023

Conversation

connor-baer
Copy link
Member

Purpose

Describe what you are trying to accomplish

Approach and changes

  • Limit the depth of the import/no-cycle rule to improve performance
  • Disable the import/no-anonymous-default-export rule in story files
  • Disable the jest/unbound-method rule
  • Remove Jest globals

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner April 16, 2023 09:18
@connor-baer connor-baer requested review from tareqlol and removed request for a team April 16, 2023 09:18
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

🦋 Changeset detected

Latest commit: 12b4c45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #854 (12b4c45) into next (a1e9345) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next     #854      +/-   ##
==========================================
- Coverage   68.66%   68.58%   -0.09%     
==========================================
  Files          18       18              
  Lines         383      382       -1     
  Branches       64       64              
==========================================
- Hits          263      262       -1     
  Misses        111      111              
  Partials        9        9              
Impacted Files Coverage Δ
src/configs/eslint/config.ts 95.00% <ø> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@connor-baer connor-baer merged commit 8f3630f into next Apr 16, 2023
@connor-baer connor-baer deleted the feature/tweak-rules branch April 16, 2023 09:23
This was referenced Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant