Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storybook's ESLint plugin #911

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

connor-baer
Copy link
Member

Purpose

Storybook released an official ESLint plugin 2 years ago.

Approach and changes

  • Enable Storybook's ESLint plugin with the recommended rules if storybook is installed

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner December 1, 2023 12:23
@connor-baer connor-baer requested review from tareqlol and removed request for a team December 1, 2023 12:23
Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: 50f9393

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f392d28) 68.01% compared to head (50f9393) 68.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #911      +/-   ##
==========================================
+ Coverage   68.01%   68.26%   +0.25%     
==========================================
  Files          18       18              
  Lines         372      375       +3     
  Branches       63       64       +1     
==========================================
+ Hits          253      256       +3     
  Misses        110      110              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer merged commit 9e9d2c2 into next Dec 1, 2023
5 checks passed
@connor-baer connor-baer deleted the feature/eslint-plugin-storybook branch December 1, 2023 12:28
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant