Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Prettier v3 #912

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Upgrade to Prettier v3 #912

merged 3 commits into from
Dec 1, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Dec 1, 2023

Purpose

Prettier v3 was released in July 2023. The most notable change for us is the migration to ESM and a fully asynchronous API. Prettier is still compatible with CJS codebases and doesn't break Foundry's support for ESLint (which doesn't support ESM yet).

Approach and changes

  • Upgrade to Prettier v3
  • Migrate to the asynchronous API

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: 959aff7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@connor-baer connor-baer mentioned this pull request Dec 1, 2023
3 tasks
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d49597) 63.45% compared to head (959aff7) 63.50%.

Files Patch % Lines
src/lib/files.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #912      +/-   ##
==========================================
+ Coverage   63.45%   63.50%   +0.05%     
==========================================
  Files          26       26              
  Lines        1970     1973       +3     
  Branches       95       95              
==========================================
+ Hits         1250     1253       +3     
  Misses        712      712              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer marked this pull request as ready for review December 1, 2023 14:10
@connor-baer connor-baer requested a review from a team as a code owner December 1, 2023 14:10
@connor-baer connor-baer requested review from tareqlol and removed request for a team December 1, 2023 14:10
@connor-baer connor-baer merged commit df2477b into next Dec 1, 2023
5 checks passed
@connor-baer connor-baer deleted the feature/prettier-3 branch December 1, 2023 14:11
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant