Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to debug command #931

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Add more info to debug command #931

merged 3 commits into from
Jan 24, 2024

Conversation

connor-baer
Copy link
Member

Purpose

Foundry does a lot of magic to detect the appropriate configuration for a project. When it fails, it can be difficult to debug why. The debug command is intended to enable developers to inspect the detected options.

Approach and changes

  • Log detected configuration
  • Remove the obsolete publish option

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner January 24, 2024 10:49
@connor-baer connor-baer requested review from tareqlol and removed request for a team January 24, 2024 10:49
Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 9fb6487

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (957f1da) 63.95% compared to head (6587b2e) 63.87%.

❗ Current head 6587b2e differs from pull request most recent head 9fb6487. Consider uploading reports for the commit 9fb6487 to get more accurate results

Files Patch % Lines
src/cli/debug.ts 0.00% 13 Missing ⚠️
src/lib/logger.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #931      +/-   ##
==========================================
- Coverage   63.95%   63.87%   -0.08%     
==========================================
  Files          29       29              
  Lines        2258     2259       +1     
  Branches      117      117              
==========================================
- Hits         1444     1443       -1     
- Misses        804      806       +2     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer merged commit 39b28a8 into next Jan 24, 2024
3 checks passed
@connor-baer connor-baer deleted the feature/debug-command branch January 24, 2024 10:53
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant