Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test plugin scope to better support monorepos #932

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

connor-baer
Copy link
Member

Purpose

End-to-end tests might be nested in a subfolder inside monorepos.

Approach and changes

  • Changed the file glob to account for nested e2e test folders

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner January 26, 2024 16:51
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team January 26, 2024 16:51
Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: d7b1b8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09a7d13) 63.87% compared to head (d7b1b8a) 63.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #932   +/-   ##
=======================================
  Coverage   63.87%   63.87%           
=======================================
  Files          29       29           
  Lines        2259     2259           
  Branches      117      117           
=======================================
  Hits         1443     1443           
  Misses        806      806           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@larimaza larimaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎖️

@connor-baer connor-baer merged commit 85b5fbe into next Jan 26, 2024
8 checks passed
@connor-baer connor-baer deleted the fix/cypress-monorepo branch January 26, 2024 16:54
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants