Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package version parsing more robust #934

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

connor-baer
Copy link
Member

Purpose

It's a common practice at SumUp to install internal packages using the direct tarball URL. Foundry failed to parse the package version in this case and errored.

Approach and changes

  • Extract the package version from tarball URLs
  • Gracefully fail if a package version can't be parsed

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from larimaza January 29, 2024 12:23
@connor-baer connor-baer requested a review from a team as a code owner January 29, 2024 12:23
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team January 29, 2024 12:23
Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 74b0e3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@connor-baer connor-baer merged commit 1f3067e into next Jan 29, 2024
6 checks passed
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa6f69e) 63.87% compared to head (74b0e3e) 64.14%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #934      +/-   ##
==========================================
+ Coverage   63.87%   64.14%   +0.26%     
==========================================
  Files          29       29              
  Lines        2259     2276      +17     
  Branches      117      121       +4     
==========================================
+ Hits         1443     1460      +17     
  Misses        806      806              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer deleted the fix/unparseable-versions branch January 29, 2024 12:24
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant