Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend version range for eslint-plugin-playwright #954

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Mar 5, 2024

Purpose

eslint-plugin-playwright v1 was released recently.

Approach and changes

  • Verified that Foundry works with v1 and updated the supported version range
  • Encouraged pull requests to update the supported version range

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 4859a17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (7f8d8e7) to head (4859a17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   65.61%   65.61%           
=======================================
  Files          29       29           
  Lines        2312     2312           
  Branches      125      125           
=======================================
  Hits         1517     1517           
  Misses        786      786           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer marked this pull request as ready for review March 14, 2024 12:50
@connor-baer connor-baer requested a review from a team as a code owner March 14, 2024 12:50
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team March 14, 2024 12:50
@connor-baer connor-baer merged commit 08122eb into main Mar 14, 2024
7 checks passed
@connor-baer connor-baer deleted the feature/playwright-v1 branch March 14, 2024 12:52
@connor-baer connor-baer mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant