Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Circuit UI's Stylelint plugin #956

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Mar 14, 2024

Purpose

Circuit UI offers both an ESLint and a Stylelint plugin to ensure the correct usage of its design tokens.

Approach and changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: ab4b208

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 99.21260% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.56%. Comparing base (08122eb) to head (ab4b208).

Files Patch % Lines
src/lib/options.ts 98.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   65.61%   66.56%   +0.95%     
==========================================
  Files          29       29              
  Lines        2312     2381      +69     
  Branches      125      134       +9     
==========================================
+ Hits         1517     1585      +68     
- Misses        786      787       +1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer marked this pull request as ready for review March 14, 2024 13:29
@connor-baer connor-baer requested a review from a team as a code owner March 14, 2024 13:29
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team March 14, 2024 13:29
@connor-baer connor-baer merged commit 1855159 into main Mar 14, 2024
7 checks passed
@connor-baer connor-baer deleted the feature/stylelint-circuit-ui branch March 14, 2024 13:31
@connor-baer connor-baer mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant