-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade eslint-config-airbnb-typescript and @typescript-eslint/* packages to latest #963
Conversation
Hey @davilima6, Thanks! |
🦋 Changeset detectedLatest commit: 4485f4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
=======================================
Coverage 55.40% 55.40%
=======================================
Files 29 29
Lines 2366 2366
Branches 138 138
=======================================
Hits 1311 1311
Misses 1037 1037
Partials 18 18 ☔ View full report in Codecov by Sentry. |
This would be super useful bump! 🙌 |
I'm currently failing to sign the CLA to unblock this PR (the page doesn't seem to work). Needs actual testing too, and a changelog entry. Hopefully I'll have time to move on with it this week or by the beginning of the next one. In the meantime, if anyone wants to push this forward just let me know. |
@davilima6 You don't need to sign the CLA since you're employed by SumUp. The CLA bot has been broken for a while 😞 I'll make a PR to remove the requirement and discourage external contributions. Edit: #969 has been merged and I've disabled the CLArk GitHub App. Pushing another commit should get rid of the failing check. |
This will have to be released as a breaking change since |
@connor-baer , thanks for having a look. Your merge commit has cleared the check failure. I don't think there's a rush to release this, so we could batch with other breaking changes. Are there any others in sight? |
@davilima6 ESLint v9 was released a month ago and I was hoping to upgrade to it with the next major. However, a lot of the plugins we use aren't compatible yet, so I'm open to releasing one sooner. |
@connor-baer, got it. Since this breaking change shouldn't be a too hard issue for users (afaik), I bumped the versions to latest and added a changeset, so feel also free to edit it directly, as well as release whenever you think it's best. If you need any other adjustments, just let me know. I'll try to test later in our project using Yalc. |
…eslint/{eslint-plugin,parser} to latest
80d0275
to
4485f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Addresses .
Purpose
This PR upgrades a couple of linter-related libraries to facilitate the upgrade of Typescript to latest in consuming projects
Currently, using TS >= 5.4.0 results in a linter warning similar to this (incl. in this very repo):
Approach and changes
eslint-config-airbnb-typescript
to latest^18.0.0
@typescript-eslint/{estlint-plugin,parser}
to latest^7.5.0
(maybe this needs to be instead^6.22.0 || ^7.5.0
? 🤔), fixing the error aboveDefinition of done