Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZSH completion #10

Closed
tmerse opened this issue Apr 25, 2016 · 5 comments
Closed

ZSH completion #10

tmerse opened this issue Apr 25, 2016 · 5 comments

Comments

@tmerse
Copy link

tmerse commented Apr 25, 2016

Thanks for this awesome plugin, this really improved my terminal based workflow.

I created a small zsh completion snippet. Maybe it is helpful.
https://gist.github.com/tmerse/851722c0c03cd442265ec523500c78c6

Created a pr for oh-my-zsh aswell.

Again, thanks for bringing dash to the linux commandline.
@sunaku
Copy link
Owner

sunaku commented Apr 27, 2016 •
edited

Thanks for your contribution! 👍

Should I add the snippet to the README or add it as a source-able file in the Git repo?

@tmerse
Copy link
Author

tmerse commented Apr 30, 2016

I don't have any preference.
You should go with what fits the project philosophy best (many features? unixy?).
I would see this in README-land though as shells may vary and It's rather far from core functionality.

@sunaku
Copy link
Owner

sunaku commented Apr 30, 2016

Cool, I'll create an etc/ folder to house this snippet and add similar completion for BASH etc. 💡

@tmerse
Copy link
Author

tmerse commented May 1, 2016

👍

sunaku added a commit that referenced this issue May 2, 2016
@sunaku
GH-10: add TAB completion for ZSH under etc/zsh/
e294bcf 
Thanks to Tobias Mersmann (@tmerse) for suggesting this feature and
providing starter code, which I extended to all dasht* executables.
@sunaku
Copy link
Owner

sunaku commented May 2, 2016

Done in commit e294bcf for all dasht executables. 🎅 Thanks again. 🙇

@sunaku sunaku closed this as completed May 2, 2016
sunaku added a commit that referenced this issue May 2, 2016
@sunaku
GH-10: add TAB completion for ZSH under etc/zsh/
59e48fd 
Thanks to Tobias Mersmann (@tmerse) for suggesting this feature and
providing starter code, which I extended to all dasht* executables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunaku @tmerse