Fix dasht-server-http serving "400 Bad Request" on requests for "/" #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported in #51. It's not clear to me if this only affects macOS users. The problem was the `grep` query changed in this commit doesn't match queries for "/": ~ $ cat urls / /? /?query /foo /bar ~ $ cat urls | grep '^/$\|^/?' /? /?query The two patterns to match for are fairly simple, so they can instead be tested for with simple string equality checks.
|
Looks good upon visual inspection. I'll test and merge soon. Thanks! 🙇 |
|
LOL 😂 Turns out we already discussed this implementation in issue #51 --- it's been so long that I've forgotten. 😅 Merged. |
|
Indeed, thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported in #51. It's not clear to me if this only affects
macOS users.
The problem was the
grepquery changed here doesn't match queries for "/":The two patterns to match for are fairly simple, so they can instead be tested
for with simple string equality checks.