Remove READ_BUFFER.
#133
Merged
Remove READ_BUFFER.
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`READ_BUFFER` was originally added for `read`, but `read` no longer needs it now that we can use `rustix::io::read_uninit`. So the only thing left using `READ_BUFFER` is the xattr functions. It wasn't really correct for the xattr functions to use a `PIPE_BUF`-sized buffer anyway, so remove `READ_BUFFER` entirely and just use `Vec`s for their buffers. This also fixes compile errors with u8/i8 mismatches when `linux-raw-sys/std` is enabled. Fixes #132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ_BUFFERwas originally added forread, butreadno longer needs it now that we can userustix::io::read_uninit. So the only thing left usingREAD_BUFFERis the xattr functions. It wasn't really correct for the xattr functions to use aPIPE_BUF-sized buffer anyway, so removeREAD_BUFFERentirely and just useVecs for their buffers.This also fixes compile errors with u8/i8 mismatches when
linux-raw-sys/stdis enabled.Fixes #132.