Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Allowing format specific options #6

Merged
merged 5 commits into from
Mar 24, 2016

Conversation

mrbar42
Copy link
Contributor

@mrbar42 mrbar42 commented Mar 24, 2016

There is a use case where ts option needs to be passed down.
at the moment there is no way to pass options to the actual font generation module.

the PR adds a formatOptions object that allows passing arbitrary options to the specific format generator.

with the additions, the usage would be as follows:

var webfontsGenerator = require('webfonts-generator')

webfontsGenerator({
  formatOptions: {
    // options to pass specifically to the ttf generator
    ttf: {
        ts: 1451512800000
    }
  }
}, function(error, result) {})

@sunflowerdeath
Copy link
Owner

It looks useful. Thank you for improvement.

@mrbar42 mrbar42 deleted the patch-1 branch March 24, 2016 10:21
@mrbar42
Copy link
Contributor Author

mrbar42 commented Mar 24, 2016

can you by any chance publish this to npm as a patch or a minor?

@sunflowerdeath
Copy link
Owner

im working on it right now )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants